Skip to content

Match zCamera sdata2 section#539

Merged
mattbruv merged 2 commits intomainfrom
zCamera_sdata2
May 13, 2025
Merged

Match zCamera sdata2 section#539
mattbruv merged 2 commits intomainfrom
zCamera_sdata2

Conversation

@stravant
Copy link
Collaborator

@stravant stravant commented May 12, 2025 •
edited
Loading

  • Migrate extern floats to actual constants.

  • Tweak the existing constants to be bitwise correct.

  • Move some forward declares to the anonymous namespace they should have been in.

  • Start reversing zCameraUpdate.

@stravant stravant changed the title Match zCamera sdata section Match zCamera sdata2 section May 12, 2025
@stravant
Match zCamera sdata section
1078864 
* Migrate extern floats to actual constants.

* Tweak some float constants which were not bitwise correct.

* Move some forward declares to the anonymous namespace they should have
  been in.

* Start zCameraUpdate.
@github-actions
Copy link

github-actions bot commented May 12, 2025

⚠️ 🔥

+138 bytes
🆗 Bot Rating: A fair and commendable contribution

Regressions: 1

⚠️ main/SB/Game/zCamera - zCameraFreeLookSetGoals(xCamera*, float, float&, float&, float&, float&, float) -32 bytes -> 95.83%

Progress: 4

📈 main/SB/Game/zCamera - .text +55 bytes -> 50.04%
📈 main/SB/Game/zCamera - .sdata2 +50 bytes -> 80.00%
📈 main/SB/Game/zCamera - zCameraUpdate(xCamera*, float) +84 bytes -> 2.16%
📈 main/SB/Game/zCamera - zCameraReset(xCamera*) +4 bytes -> 72.58%

@bfbbdecomp bfbbdecomp deleted a comment from github-actions bot May 12, 2025
@stravant
Copy link
Collaborator Author

stravant commented May 12, 2025

(Also, didn't mean to branch on the main repo instead of the fork, used to doing that from another project at the moment so muscle memory)

JoshSanch
JoshSanch reviewed May 12, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented May 13, 2025

⚠️ 🔥

+138 bytes
🆗 Bot Rating: A fair and commendable contribution

Regressions: 13

⚠️ main/SB/Core/gc/ngcrad3d - .bss -40 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - .sbss -8 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - .sdata2 -30 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - .text -500 bytes -> 0.00%
⚠️ main/SB/Game/zCamera - zCameraFreeLookSetGoals(xCamera*, float, float&, float&, float&, float&, float) -32 bytes -> 95.83%
⚠️ main/SB/Core/gc/ngcrad3d - Open_RAD_3D_image -232 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - Close_RAD_3D_image -76 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - Lock_RAD_3D_image -80 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - Unlock_RAD_3D_image -48 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXEnd -4 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXTexCoord2f32 -16 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXColor4u8 -24 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXPosition3s16 -20 bytes -> 0.00%

Progress: 4

📈 main/SB/Game/zCamera - .text +55 bytes -> 50.04%
📈 main/SB/Game/zCamera - .sdata2 +50 bytes -> 80.00%
📈 main/SB/Game/zCamera - zCameraUpdate(xCamera*, float) +84 bytes -> 2.16%
📈 main/SB/Game/zCamera - zCameraReset(xCamera*) +4 bytes -> 72.58%

@mattbruv mattbruv merged commit c9e1688 into main May 13, 2025
10 checks passed
@stravant stravant deleted the zCamera_sdata2 branch May 13, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshSanch JoshSanch JoshSanch left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stravant @JoshSanch @mattbruv